-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User inheritance and roles #627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alneberg
reviewed
Oct 12, 2021
alneberg
reviewed
Oct 12, 2021
alneberg
reviewed
Oct 12, 2021
alneberg
reviewed
Oct 12, 2021
alneberg
reviewed
Oct 12, 2021
alneberg
reviewed
Oct 12, 2021
alneberg
reviewed
Oct 12, 2021
Closed
alneberg
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to work!
aanil
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joined table inheritance for users:
User
: Base user table, including all rows which all user types should haveResearchUser
: Connected to projects via theProjectUsers
association table.owner
which allows the user to be a projectowner for some projects (with some admin permissions) and only a team member in some (only list and download permissions)UnitUser
: Does not have a connection to the projects table directly, only through the connected unit.is_admin
column:Unit Personnel
/Unit Admin
SuperAdmin
: Us at DC -- we can do anything. Not a lot implemented here, mostly focusing on the others.The endpoints should also be fixed so that they have
@auth.login_required(roles=[".."])
where it's applicable.NOTE! The code is being refactored, this is an initial PR for the roles and inheritance to work. This is due to that the PR will become huge if I do everything at once.