-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/checkout to v4 #1556
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1556 +/- ##
==========================================
+ Coverage 92.52% 92.53% +0.01%
==========================================
Files 29 29
Lines 4868 4878 +10
==========================================
+ Hits 4504 4514 +10
Misses 364 364 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprintlog and check the scan boxes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if we shouldn't update all instances of actions/checkout@v4
and not only this workflow file?
Also, I updated the branch and resolved the sprintlog, and now checks are failing again, not sure why?
Again the too many requests, if you run it locally with the vpn it also hits it. Yesterday it also happened a lot with the PRs. They must have decreased the limits recently or there is something that changed, because it is too much of a coincidence now I read somewhere a solution to cache images to avoid pulling them in the Actions everytime, only solution for now is to re-run the jobs after a time |
🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I cannot "Approve" or "Request changes" here, only "Comment".
It looks good, maybe as Ina suggested we should bump this action in all our workflows.
@valyo You can't approve because you created the PR 😄 So you're the one making potential changes to the other actions as well |
🙃 |
ok, if we have agreed that all actions should be bumped, I'll add the changes in this PR |
Yes go ahead and do that |
@valyo This was a mistake on my end. I was suppose to push to my PR. I'll fix this PR instead. |
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Bump checkout action to v4, after noticing warning:
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.