DDS-2018: Build Technical Overview PDF in GitHub Action #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishling-scilifelab
force-pushed
the
DDS-2018-build-tech-overview
branch
5 times, most recently
from
a76e67b to
0d6d0bf
Compare
aishling-scilifelab
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1541 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 29 29
Lines 4850 4850
=======================================
Hits 4486 4486
Misses 364 364 ☔ View full report in Codecov by Sentry. |
rv0lt
requested changes
Jul 19, 2024
| <br> | ||
| <div class="tech-overview-container"> |
There was a problem hiding this comment.
I think the download option is enough. As everything stored in /static is always accessible through the URL
There was a problem hiding this comment.
Great, I like that option too :)
- Modify build workflow to first run pandoc to build the PDF. - Delete the pre-built PDF as MD tracked instead. - Bump some actions to v4 due to deprecation warnings. - Remove option from UI to read in GitHub - Update name of PDF to dds-technical-overview because it's nice to have DDS included when it's downloaded to the user's computer.
- Actually setting the font using the LaTeX command on L13
- No support for Windows developers. - Add command to update tlmgr with the necessary packages and convert the existing markdown file to a PDF. - Could move multiple commands in there from the README.md
aishling-scilifelab
force-pushed
the
DDS-2018-build-tech-overview
branch
from
0d6d0bf to
90b2ee2
Compare
rv0lt
approved these changes
Jul 19, 2024
|
@rv0lt in addition to getting rid of the embedded PDF, I also renamed the downloaded PDF to be dds-technical-overview.pdf on the basis that it's kind of useful to have it labelled as DDS when it's on the user's computer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Add a summary of the changes in this PR and the related issue.
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
masterbranch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.