Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS-1905: Correct outdated information in Technical Overview #1540

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

aishling-scilifelab
Copy link
Contributor

@aishling-scilifelab aishling-scilifelab commented Jul 16, 2024

  • Correct outdated info about S3 keys
  • Add line about extending the deadline for a project

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Add a summary of the changes in this PR and the related issue.

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

- Correct outdated info about S3 keys
- Add line about extending the deadline for a project
- Update SPRINTLOG.md
@aishling-scilifelab aishling-scilifelab force-pushed the DDS-1905-update-tech-overview branch from 92627de to b908a08 Compare July 16, 2024 11:38
@aishling-scilifelab aishling-scilifelab marked this pull request as ready for review July 16, 2024 11:39
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (abccb24) to head (b908a08).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1540   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          29       29           
  Lines        4850     4850           
=======================================
  Hits         4486     4486           
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aishling-scilifelab aishling-scilifelab merged commit c4aeea5 into dev Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants