Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version & changelog #1532

Merged
merged 3 commits into from
May 30, 2024
Merged

New version & changelog #1532

merged 3 commits into from
May 30, 2024

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented May 29, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

New version and changelog for release

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this May 29, 2024
@rv0lt rv0lt changed the title version & changelog New version & changelog May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (06e97d9) to head (09401ef).

Current head 09401ef differs from pull request most recent head d1471db

Please upload reports for the commit d1471db to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1532   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          29       29           
  Lines        4808     4808           
=======================================
  Hits         4444     4444           
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rv0lt rv0lt requested a review from a team May 29, 2024 09:58
@rv0lt rv0lt marked this pull request as ready for review May 29, 2024 09:58
CHANGELOG.rst Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@rv0lt rv0lt requested a review from aishling-scilifelab May 30, 2024 09:15
CHANGELOG.rst Outdated Show resolved Hide resolved
@rv0lt rv0lt requested a review from aishling-scilifelab May 30, 2024 10:46
Copy link
Contributor

@aishling-scilifelab aishling-scilifelab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

Not saying you have to here but this could be a use of squashing (i.e. squashing the commits on this branch into 1 before merging) because it's really one change and the latter 2 commits are amendments to that change

https://www.git-tower.com/learn/git/faq/git-squash

@rv0lt rv0lt merged commit dd770b3 into dev May 30, 2024
13 checks passed
@rv0lt rv0lt deleted the new_release branch May 30, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants