Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOs actions image due to broken pipeline #700

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Jun 4, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Fix broken changes in actions due to updtae in architecutre for underliying image

2. Jira task / GitHub issue

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Jun 4, 2024
@rv0lt rv0lt changed the title update actions due to broken pipeline Update MacOs actions image due to broken pipeline Jun 4, 2024
@rv0lt
Copy link
Member Author

rv0lt commented Jun 4, 2024

For reference: Change motivated by the issue explained in actions/runner-images#9741 (comment)

Where the architecture for the default MacOs image is arm instead of Intel.

@rv0lt rv0lt requested a review from a team June 4, 2024 10:48
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we adding a build for macos-latest, or will this one work on MacOS 14 too

@rv0lt
Copy link
Member Author

rv0lt commented Jun 4, 2024

Aren't we adding a build for macos-latest, or will this one work on MacOS 14 too

As I understand, it won't work for AMD based Mac's. I.e, the new M1 and M2, for example, as they don't use intel chips anymore.

But we were already only building for x86 archs anyway

@valyo
Copy link
Member

valyo commented Jun 4, 2024

Yes, but we should definitely have binaries for the arm arch MacOS. Maybe we should go for x86 now since we are running out of time.
What is this "The base branch requires all commits to be signed" business about?

@rv0lt rv0lt force-pushed the actions-fail-release branch from 6af8892 to 338f744 Compare June 4, 2024 12:04
@rv0lt rv0lt force-pushed the actions-fail-release branch from 338f744 to 9778797 Compare June 4, 2024 12:06
@rv0lt rv0lt merged commit b3a7cc7 into dev Jun 4, 2024
15 checks passed
@rv0lt rv0lt deleted the actions-fail-release branch June 4, 2024 12:08
@rv0lt
Copy link
Member Author

rv0lt commented Jun 4, 2024

Yes, but we should definitely have binaries for the arm arch MacOS. Maybe we should go for x86 now since we are running out of time. What is this "The base branch requires all commits to be signed" business about?

Yes, I was thinking we need some task to rethink this actions bussiness as they are giving more trouble than they should.

My fault, I don't know how but my GPG got deleted after updating the laptop. Now it is rebased

@rv0lt rv0lt mentioned this pull request Jun 4, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants