-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MacOs actions image due to broken pipeline #700
Conversation
For reference: Change motivated by the issue explained in actions/runner-images#9741 (comment) Where the architecture for the default MacOs image is arm instead of Intel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we adding a build for macos-latest
, or will this one work on MacOS 14 too
As I understand, it won't work for AMD based Mac's. I.e, the new M1 and M2, for example, as they don't use intel chips anymore. But we were already only building for x86 archs anyway |
Yes, but we should definitely have binaries for the arm arch MacOS. Maybe we should go for x86 now since we are running out of time. |
6af8892
to
338f744
Compare
338f744
to
9778797
Compare
Yes, I was thinking we need some task to rethink this actions bussiness as they are giving more trouble than they should. My fault, I don't know how but my GPG got deleted after updating the laptop. Now it is rebased |
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Fix broken changes in actions due to updtae in architecutre for underliying image
2. Jira task / GitHub issue
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.