-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDS-1942 update docs for testing migration #691
DDS-1942 update docs for testing migration #691
Conversation
I think Sprintlog is always necessary to add an entry to keep track |
I assume the way to use the sprintlog is:
Then, when we do a release we digest the info in the sprint logs into user-facing text for the CHANGELOG.rst? Edit: Will interactive rebase the branch to incorporate that change. |
Yes, add a new line per PR. With the same format as the other ones. You can run prettier to check the style, otherwise the lint will fail. Then, on release day. In the changelog will only be mentioned changes that will be seen/affected by the user (ex: Changes on the Actions will not be mentioned there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only thing needed is a sprintlog entry
dd306ef
to
f94e37b
Compare
f94e37b
to
ad5d519
Compare
ad5d519
to
94ff246
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #691 +/- ##
==========================================
- Coverage 47.76% 47.74% -0.02%
==========================================
Files 31 31
Lines 2887 2886 -1
==========================================
- Hits 1379 1378 -1
Misses 1508 1508 ☔ View full report in Codecov by Sentry. |
- When talking about the Testing instance of DDS, the existing doc claims there is *no* risk. Bit pedantic but there is never no risk. - Furthermore, as the users of this Testing instance should not be using it for any sensitive deliveries, this should not be an issue.
- The testing instance != dev and use 'testing', rather than test. - Update mentioned URLs from https://dds-dev.dckube3.scilifelab.se/ to https://testing.delivery.scilifelab.se/ as the testing instance is migrating to this new address. - Update SPRINGLOG.md
94ff246
to
8f65813
Compare
1. Description / Summary
Updating the user-facing documentation for the migration of the Testing instance.
Also, in a separate commit, removed a sentence that said there was no risk. Can move this commit to its own branch, if preferred.
2. Jira task / GitHub issue
DDS-1942
3. Type of change
What type of change(s) does the PR contain?
4. Additional information
master
branch: If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.