Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Timeout exception #563

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Catch Timeout exception #563

merged 3 commits into from
Oct 28, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Oct 28, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

When a requests takes too long, it times out, currently leading to the error message ERROR Expecting value: line 1 column 1 (char 0). This PR catches the timeout exception and prints a more understandable message.

  • Add a summary of the changes and the related issue
  • Fixes DDS-1402

Type of change

  • Bug fix (non-breaking)

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • The tests pass

@i-oden i-oden self-assigned this Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #563 (ecf7c35) into dev (46c036c) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev     #563      +/-   ##
==========================================
- Coverage   45.32%   45.31%   -0.02%     
==========================================
  Files          29       29              
  Lines        2621     2626       +5     
==========================================
+ Hits         1188     1190       +2     
- Misses       1433     1436       +3     
Impacted Files Coverage Δ
dds_cli/utils.py 98.36% <50.00%> (-1.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden requested a review from valyo October 28, 2022 08:17
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@i-oden i-oden merged commit c2a4528 into dev Oct 28, 2022
@i-oden i-oden deleted the DDS-1402-error-when-aborting-project branch October 28, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants