Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display creator when listing projects #557

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Oct 14, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

New column in project table to display name or creator.

  • Add a summary of the changes and the related issue
  • Fixes DDS-1393

Type of change

  • New feature (non-breaking)

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • The tests pass

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #557 (7d355eb) into dev (58e6f29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #557   +/-   ##
=======================================
  Coverage   43.29%   43.29%           
=======================================
  Files          29       29           
  Lines        2601     2601           
=======================================
  Hits         1126     1126           
  Misses       1475     1475           
Impacted Files Coverage Δ
dds_cli/data_lister.py 13.61% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden self-assigned this Oct 14, 2022
@i-oden i-oden requested a review from valyo October 14, 2022 11:48
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works

@i-oden i-oden merged commit d88be58 into dev Oct 19, 2022
@i-oden i-oden deleted the DDS-1393-show-creator-of-project branch October 19, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants