Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for checking for busy projects #536

Merged
merged 7 commits into from
Sep 28, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Sep 27, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Adds a command busy to the dds project status command for checking if there are busy projects.

  • Add a summary of the changes and the related issue
  • Add motivation and context regarding why the change is needed
  • Fixes DDS-1352

Type of change

  • New feature (non-breaking)

Checklist:

General

  • I have added a row in the changelog
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • The tests pass

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #536 (7babe23) into dev (7e0cd1a) will decrease coverage by 0.02%.
The diff coverage is 26.92%.

@@            Coverage Diff             @@
##              dev     #536      +/-   ##
==========================================
- Coverage   40.47%   40.45%   -0.03%     
==========================================
  Files          29       29              
  Lines        2594     2620      +26     
==========================================
+ Hits         1050     1060      +10     
- Misses       1544     1560      +16     
Impacted Files Coverage Δ
dds_cli/project_status.py 28.57% <18.75%> (-3.35%) ⬇️
dds_cli/__main__.py 41.84% <40.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
@valyo valyo marked this pull request as ready for review September 28, 2022 07:35
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! The change to the docstring and the f-string should be changed, the last comment is just a personal preference and it's up to you if you want to change it now

dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
@valyo valyo requested a review from i-oden September 28, 2022 14:15
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@i-oden i-oden merged commit 05b5ac1 into dev Sep 28, 2022
@i-oden i-oden deleted the DDS-1352_add_command_busy_projects branch September 28, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants