Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance command for setting maintenance mode #535

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Sep 21, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Add commands dds maintenance on and dds maintenance off for turning Maintenance mode on and off
works with ScilifelabDataCentre/dds_web#1286

  • Add a summary of the changes and the related issue
  • Add motivation and context regarding why the change is needed
  • Fixes DDS-1348

Type of change

  • New feature (non-breaking)

Checklist:

General

  • I have added a row in the changelog
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Blocking PRs have been merged
  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • The tests pass

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #535 (110e68f) into dev (b9ad4f7) will increase coverage by 0.18%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##              dev     #535      +/-   ##
==========================================
+ Coverage   41.92%   42.10%   +0.18%     
==========================================
  Files          29       30       +1     
  Lines        2645     2674      +29     
==========================================
+ Hits         1109     1126      +17     
- Misses       1536     1548      +12     
Impacted Files Coverage Δ
dds_cli/__main__.py 41.87% <45.45%> (+0.06%) ⬆️
dds_cli/maintenance_manager.py 64.70% <64.70%> (ø)
dds_cli/__init__.py 91.25% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the "dds maintenance on/off" command. My suggestion regards reducing some code duplication, otherwise it'll work the exact same way

dds_cli/__main__.py Outdated Show resolved Hide resolved
@i-oden i-oden self-requested a review September 21, 2022 10:56
@i-oden i-oden merged commit 6fd2d19 into dev Sep 22, 2022
@i-oden i-oden deleted the DDS-1348_maintenance_command branch September 22, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants