Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dds auth twofactor split up into configure and deactivate #519

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 17, 2022

Description

Matches: ScilifelabDataCentre/dds_web#1247

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version
  • I am bumping the major version (e.g. 1.x.x to 2.x.x) and I have made the corresponding changes to the API version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@i-oden i-oden self-assigned this Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #519 (9c90075) into dev (459c8d8) will decrease coverage by 0.00%.
The diff coverage is 51.85%.

@@            Coverage Diff             @@
##              dev     #519      +/-   ##
==========================================
- Coverage   42.19%   42.19%   -0.01%     
==========================================
  Files          29       29              
  Lines        2576     2595      +19     
==========================================
+ Hits         1087     1095       +8     
- Misses       1489     1500      +11     
Impacted Files Coverage Δ
dds_cli/user.py 19.07% <ø> (ø)
dds_cli/auth.py 40.54% <20.00%> (-0.64%) ⬇️
dds_cli/__main__.py 41.32% <52.63%> (-0.24%) ⬇️
dds_cli/__init__.py 90.90% <100.00%> (+0.11%) ⬆️
dds_cli/options.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden changed the title dds auth twofactor split up into activate and deactivate dds auth twofactor split up into configure and deactivate Aug 18, 2022
dds_cli/user.py Outdated Show resolved Hide resolved
dds_cli/user.py Outdated Show resolved Hide resolved
dds_cli/user.py Outdated Show resolved Hide resolved
@i-oden i-oden merged commit 3efa8b2 into dev Aug 18, 2022
@i-oden i-oden deleted the twofactorfix branch August 18, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant