-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse project specific errors from API #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #491 +/- ##
========================================
+ Coverage 6.54% 7.17% +0.62%
========================================
Files 29 29
Lines 2430 2440 +10
========================================
+ Hits 159 175 +16
+ Misses 2271 2265 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns the parsing of the project related
"errors"
, specifically when adding a user to a project you do not have access to (i.e. your project key does not exist). The PR also returns these errors to the underlying functions, which means all calls toperform_request
are changed by adding an extra returned variable (_
because unused for most cases).Fixes DDS-1265
Type of change
Checklist:
Please delete options that are not relevant.
master
branch and I have updated the versionFormatting and documentation
Tests
Manual tests to try out
ProjectUserKeys
dds user add
a. Invite a new Researcher to project --> Error:
dds user add [email protected] -r Researcher -p project_1
b. Invite new Unit Personnel --> Error:
dds user add [email protected] -r Unit Personnel
c. Add existing Unit Personnel to project as Researcher --> Error:
dds user add [email protected] -r Researcher -p project_1
d. Add existing Researcher to project --> Error:
dds user add [email protected] -r Researcher -p project_1
dds project access fix
a. Fix project access for all projects for Unit Personnel --> Error:
dds project access fix [email protected]
b. Fix project access for Researcher
a.
dds project create
b.
dds motd add