Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor version handling to allow PyInstaller builds #439

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Refactor version handling to allow PyInstaller builds #439

merged 2 commits into from
Mar 28, 2022

Conversation

MatthiasZepper
Copy link
Contributor

Before submitting a PR to the dev branch:

  • [x ] Tests passing
  • [x ] Black formatting
  • [x ] Rebase/merge the dev branch
  • [x ] Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in setup.py (?)

@MatthiasZepper MatthiasZepper marked this pull request as ready for review March 25, 2022 21:40
talavis
talavis reviewed Mar 27, 2022
View reviewed changes
setup.py Show resolved Hide resolved
@i-oden i-oden added the must have Cannot deliver on target date without this label Mar 28, 2022
@i-oden i-oden merged commit 6f460bd into ScilifelabDataCentre:dev Mar 28, 2022
@MatthiasZepper MatthiasZepper deleted the version_info_fix branch April 4, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talavis talavis talavis left review comments

@i-oden i-oden i-oden approved these changes

Assignees

@MatthiasZepper MatthiasZepper

Labels
must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthiasZepper @talavis @i-oden