Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dds user ls command #384

Merged
merged 5 commits into from
Mar 14, 2022
Merged

New dds user ls command #384

merged 5 commits into from
Mar 14, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Mar 13, 2022 •
edited
Loading

List the Unit Admins and Unit Personnel within the authenticated users unit.

Test with: ScilifelabDataCentre/dds_web#1050

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in setup.py (?)

@i-oden i-oden self-assigned this Mar 13, 2022
@i-oden i-oden added the should have Important but not vital label Mar 13, 2022
@i-oden i-oden mentioned this pull request Mar 13, 2022
Merged
4 tasks
@i-oden i-oden added must have Cannot deliver on target date without this and removed should have Important but not vital labels Mar 13, 2022
i-oden
i-oden commented Mar 14, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@i-oden i-oden requested review from MatthiasZepper, aanil and talavis and removed request for MatthiasZepper March 14, 2022 07:53
@i-oden i-oden marked this pull request as ready for review March 14, 2022 07:53
i-oden
i-oden commented Mar 14, 2022
View reviewed changes
dds_cli/__main__.py Outdated Show resolved Hide resolved
talavis
talavis approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@talavis talavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended.

@i-oden i-oden merged commit 7ee1ab3 into dev Mar 14, 2022
@i-oden i-oden deleted the list-users-in-unit branch March 14, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talavis talavis talavis approved these changes

@aanil aanil Awaiting requested review from aanil

@MatthiasZepper MatthiasZepper Awaiting requested review from MatthiasZepper

Assignees

@i-oden i-oden

Labels
must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-oden @talavis