Improve error message when --destination exists #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Linus Östberg <[email protected]>
talavis
force-pushed
the
tweak-destinary-error
branch
from
394f291 to
7cbd7e2
Compare
i-oden
reviewed
Mar 9, 2022
This was referenced Mar 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a new custom error message when
--directoryexists, so that it's clearer what is wrong.Note that these should probably be raising exceptions rather than doing
sys.exit.. But I'm a bit behind what the current methodology is so I'll leave that for a suggestion / separate PR.Before submitting a PR to the
devbranch:devbranchAdditional checks before submitting a PR to the
masterbranch:setup.py(?)