Token path argument #329
Merged
Token path argument #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-oden
reviewed
Mar 3, 2022
| def __init__(self): | ||
| self.token_file = dds_cli.TOKEN_FILE | ||
| def __init__(self, token_path=None): | ||
| if token_path is None: |
There was a problem hiding this comment.
(Minor comment: You don't need the is None here, if not token_path also works)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new argument
--token-pathis added and used as such:I also moved the username printing for the logo inside the
dds_main. As a consequence, it will now not be printed if you rundds --helpordds --version, but otherwise it should be printed.Also, if the username is not found, for example if no token is found, it's not printed at all. This can of course be adjusted however we want to.
Feel free to squash merge this as the commits became a bit messy.
Before submitting a PR to the
devbranch:devbranchAdditional checks before submitting a PR to the
masterbranch:setup.py(?)