Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added unit and changed url #261

Merged
merged 4 commits into from
Feb 25, 2022
Merged

added unit and changed url #261

merged 4 commits into from
Feb 25, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Feb 25, 2022 •
edited
Loading

Before submitting a pr:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden i-oden self-assigned this Feb 25, 2022
@i-oden i-oden added the must have Cannot deliver on target date without this label Feb 25, 2022
MatthiasZepper
MatthiasZepper approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@MatthiasZepper MatthiasZepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix is still required, though.

dds_cli/account_manager.py Outdated Show resolved Hide resolved
aanil
aanil approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@i-oden i-oden merged commit 19f03be into dev Feb 25, 2022
@i-oden i-oden deleted the change_url branch May 11, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanil aanil aanil approved these changes

@MatthiasZepper MatthiasZepper MatthiasZepper approved these changes

Assignees

@i-oden i-oden

Labels
must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-oden @MatthiasZepper @aanil