Document a procedure for PR and merging #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I assume this is a reasonable initial policy. @PatriLoto -- I see you marked the PR description with a 'thumbs up'. Thank you -- but I am wondering if that means it is not clear how to actually submit a review using GitHub. I wonder if I needed to formally 'request a review'. I'll try that for @ScienceCore/climaterisk-team to see if it makes it more clear what to do for others. (If this is making little sense, please let me know so I can create additional documentation. Thanks) |
kvenkman
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a first pass a PR / merge policy for this repo. Review requested!