Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartopy replaces basemap #67

Closed
wants to merge 3 commits into from
Closed

cartopy replaces basemap #67

wants to merge 3 commits into from

Conversation

bblay
Copy link
Contributor

@bblay bblay commented Sep 4, 2012

Not ready to pull.

Code is now ready for review but many of the images with changed checksums exhibit the bug believed to be addressed in SciTools/cartopy#31. When this bug is fixed, the commit for the image checksums will be updated.

Also, the commit for the image results will be updated (separate repo). You can see them as they are now, here:
bblay/iris-issue-files@15cf122
Many of these images have minor changes to the border lines.

Resolves #15.

@bblay bblay closed this Sep 4, 2012
@bblay bblay reopened this Sep 5, 2012
@@ -178,6 +178,9 @@ def xml_element(self, doc):

return coord_system_xml_element

def _as_cartopy_projection(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wherever this functionality ends up, it should probably by public, not private.

@rhattersley
Copy link
Member

The install guide needs updating to reflect the new dependencies.

@pelson
Copy link
Member

pelson commented Sep 24, 2012

It would be nice to start a migration guide. Perhaps some of that could be bundled into Cartopy, but the use of iplt.gcm is a Iris specific thing.

@bblay bblay mentioned this pull request Sep 25, 2012
@bblay
Copy link
Contributor Author

bblay commented Sep 26, 2012

Away tomorrow, current status:

  • workaround removed for mpl range bug, pending pr (mpl no. 1314, from bblay/pcmrange)
  • minor cartopy pr (no. 53, from bblay/margin) required for 0 margins, as before
  • there are still image test failures to attend to

Image test failures:

  • margins still present for
    • testplot.TestContourf.test_yx
    • testplot.TestContour.test_yx
    • test_quickplot.TestQuickPlotCoordinatesGiven.test_yx
    • test_plot.TestPlotCoordinatesGiven.test_yx
  • range bug still present for
    • test_mapping.TestMappingSubRegion.test_simple
    • test_mapping.TestBoundedCube.test_grid
    • test_mapping.TestBoundedCube.test_pcolormesh

(Looking into test_grid, I discovered the transformed points in matplotlib.axes.pcolormesh, line 7505 were all inf)

@bblay bblay mentioned this pull request Sep 26, 2012
@esc24 esc24 mentioned this pull request Sep 27, 2012
@bblay
Copy link
Contributor Author

bblay commented Oct 1, 2012

Moved into #115

@bblay bblay closed this Oct 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cartopy for maps
3 participants