-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cartopy replaces basemap #67
Conversation
@@ -178,6 +178,9 @@ def xml_element(self, doc): | |||
|
|||
return coord_system_xml_element | |||
|
|||
def _as_cartopy_projection(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wherever this functionality ends up, it should probably by public, not private.
The install guide needs updating to reflect the new dependencies. |
It would be nice to start a migration guide. Perhaps some of that could be bundled into Cartopy, but the use of |
Away tomorrow, current status:
Image test failures:
(Looking into test_grid, I discovered the transformed points in matplotlib.axes.pcolormesh, line 7505 were all |
Moved into #115 |
Not ready to pull.
Code is now ready for review but many of the images with changed checksums exhibit the bug believed to be addressed in SciTools/cartopy#31. When this bug is fixed, the commit for the image checksums will be updated.
Also, the commit for the image results will be updated (separate repo). You can see them as they are now, here:
bblay/iris-issue-files@15cf122
Many of these images have minor changes to the border lines.
Resolves #15.