-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster time coordinate categorization #5999
Faster time coordinate categorization #5999
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5999 +/- ##
=======================================
Coverage 89.77% 89.78%
=======================================
Files 88 88
Lines 23037 23056 +19
Branches 5038 5027 -11
=======================================
+ Hits 20681 20700 +19
Misses 1624 1624
Partials 732 732 ☔ View full report in Codecov by Sentry. |
Would it make sense to add the example code above as a benchmark? |
0a68294
to
0065385
Compare
7fc3b5f
to
02e9d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent idea @bouweandela, we just need to come to an agreement on how best to identify the cases where we're dealing with dates.
Co-authored-by: Martin Yeo <[email protected]>
…o cftime.datetime objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, final couple of comments and I think we're ready to go 🚀
🚀 Pull Request
Description
Make time coordinate categorization faster by converting the time points to datetimes in a single call.
Example script:
while with the current
main
branch, the timing result isConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: