Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix W605 error in test_coord_op_coord_fail #5925

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Possible fix for recently observed pre-commit CI failures?


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nice, fixes the current pre-commit error.
But it's still nasty that we have a bug in the flake8 code !

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (7c313ff) to head (823bffb).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5925   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          93       93           
  Lines       22982    22988    +6     
  Branches     5006     5009    +3     
=======================================
+ Hits        20630    20636    +6     
  Misses       1622     1622           
  Partials      730      730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo merged commit fc7f832 into SciTools:main Apr 25, 2024
21 checks passed
@trexfeathers trexfeathers deleted the fix_w605 branch May 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants