Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure removal of release candidate from What's New title. #5526

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/src/whatsnew/3.7.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.. include:: ../common_links.inc

v3.7 (16 Aug 2023) [release candidate]
**************************************
v3.7 (16 Aug 2023)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #5454 this should be 31 Aug. 16 Aug was the date of the release candidate

******************

This document explains the changes made to Iris for this release
(:doc:`View all changes <index>`.)
Expand Down Expand Up @@ -46,7 +46,7 @@ This document explains the changes made to Iris for this release

#. `@rcomer`_ rewrote :func:`~iris.util.broadcast_to_shape` so it now handles
lazy data. (:pull:`5307`)

.. _concat_warnings:

#. `@acchamber`_ added error and warning messages about coordinate overlaps to
Expand All @@ -69,11 +69,11 @@ This document explains the changes made to Iris for this release
=============

#. `@acchamber`_ fixed a bug with :func:`~iris.util.unify_time_units` so it does not block
concatenation through different data types in rare instances. (:pull:`5372`)
concatenation through different data types in rare instances. (:pull:`5372`)

#. `@acchamber`_ removed some obsolete code that prevented extraction of time points
from cubes with bounded times (:pull:`5175`)

.. _cftime_warnings:

#. `@rcomer`_ modified pp-loading to avoid a ``cftime`` warning for non-standard
Expand Down
5 changes: 5 additions & 0 deletions tools/release_do_nothing.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ def finalise_whats_new(
whatsnew_title += " [release candidate]"
# TODO: automate
message = f"In {rsts.release.name}: set the page title to:\n{whatsnew_title}\n"
if not is_release_candidate:
message += (
"\nBe sure to remove any existing mentions of release "
"candidate from the title.\n"
)
_wait_for_done(message)

message = (
Expand Down
Loading