Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the benchmark fixes and enhancements to main #5437

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Merge the benchmark fixes and enhancements to main #5437

merged 10 commits into from
Aug 21, 2023

Commits on Aug 18, 2023

  1. Improve benchmark runner printing (#5429) 

    * More sensible print and run functions.

* Avoid permanent modifications in _subprocess_runner.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1bd56d5 View commit details
    Browse the repository at this point in the history

  2. Post on demand benchmark results as comment (big refactor) (#5430) 

    * On demand benchmarking.

* Correct gh query.

* Correct assignee spacing.

* What's new entry.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    58d195a View commit details
    Browse the repository at this point in the history

  3. Better comparison commits for PR benchmarking (#5431) 

    * Don't check out head_ref - benchmark the GH simulated merge commit instead.

* What's New entry.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cdbec50 View commit details
    Browse the repository at this point in the history

  4. Warn via issue if overnight benchmarks fail (#5432) 

    * Include a warning step for overnight benchmarking.

* Fix for failure warning script.

* Better formatting of warning issue title.

* What's new entry.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e5a45c2 View commit details
    Browse the repository at this point in the history

  5. Minor benchmark improvements (#5433) 

    * Use shlex.split() for bm_runner commands.

* Minor documentation clarifications.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    016fc37 View commit details
    Browse the repository at this point in the history

  6. Set benchmark runs to error if the subprocess errors (#5434) 

    * Set benchmark runs to error if the subprocess errors.

* Still compare results even from a broken run.

* Still upload reports if overnight run fails.

* What's New entry.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    25451fd View commit details
    Browse the repository at this point in the history

  7. Hard-code conda channel into asv_delegated_conda.py (#5435) 

    * What's new entry.

* What's New entry.

* Hard-code conda channel into asv_delegated_conda.py .

* Fix some rebase confusion in the What's New.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    7d801d9 View commit details
    Browse the repository at this point in the history

  8. Inflate benchmark data to ensure laziness (#5436) 

    * Inflate benchmark data to ensure laziness.

* What's New entry.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3125c3e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into FEATURE_benchmarks

    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    17d4989 View commit details
    Browse the repository at this point in the history

  10. Benchmark feature branch what's new entry (#5438) 

    * What's new entry.

* Correct user name @ESadek-MO.

* Missing colon.
    @trexfeathers
    trexfeathers authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5bda4e3 View commit details
    Browse the repository at this point in the history