Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeback (v3.3.x) #4930

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Mergeback (v3.3.x) #4930

merged 3 commits into from
Aug 25, 2022

Conversation

stephenworsley
Copy link
Contributor

Update main with changes to v3.3.x.

NOTE: Should be merged without squashing.

stephenworsley and others added 3 commits August 23, 2022 13:57
* unpin shapely

* update whatsnew
* Use setuptools_scm release-branch-semver version_scheme.

* Properly handle all possible scm-rtd combinations.

* What's new entry.

* Use git stash to protect setuptools_scm from RTD.

* Better version badges.

* Better use of git stash.

* Substitute commit SHAs in place of versions where appropriate.

* Make rtd_version safe for use in shields.io badges.

* Make rtd_version safe for use in shields.io badges.
* v3.3.x:
  Better handle `setuptools_scm` versioning (SciTools#4926)
  Unpin shapely (SciTools#4925)

# Conflicts:
#	requirements/ci/nox.lock/py310-linux-64.lock
#	requirements/ci/nox.lock/py38-linux-64.lock
#	requirements/ci/nox.lock/py39-linux-64.lock
@trexfeathers trexfeathers self-assigned this Aug 25, 2022
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I've just asked @stephenworsley to also regenerate the lock-files, since both v3.3.x and main have had their own lock-file updates at different times, and I don't want to risk any confusion.

@trexfeathers
Copy link
Contributor

This looks great. I've just asked @stephenworsley to also regenerate the lock-files, since both v3.3.x and main have had their own lock-file updates at different times, and I don't want to risk any confusion.

From further discussion: we have worked out that the lock-files on v3.3x were updated more recently than main, so there is no risk. Will merge as is.

@trexfeathers trexfeathers merged commit ce6f8b1 into SciTools:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants