v3.2.0rc0 whats new and version string #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
requested changes
Jan 31, 2022
There was a problem hiding this comment.
A couple of quick queries here ...
- is it really necessary + desirable to delete docs/whatsnew/dev.template ?
I know the dev docs say to do that, but then we have to re-introduce it post-release. I'm not convinced it does any harm to just leave it in ? - I get that docs: move whatsnew #4540 basically renamed 'latest.rst' to 'dev.rst'. We have also changed the ref in 'whatsnew/index.rst'.
And here when cutting a new release version, we rename 'dev.rst' to '3.2.rst' in the index.
but then why do we still need 'latest.rst' at all -- which is now just a link to 'dev.rst' ?
(I know this is really a question for docs: move whatsnew docs: move whatsnew #4540, but I missed the boat there)
Otherwise, 👍 LGTM !
Presumably because we want to just update the symlink rather than the toctree, but I think @bjlittle added it so might have another view? |
Not sure really! I am doing it because that's what the docs say and that is what you did for the 3.1.0rc0 |
pp-mo
approved these changes
Jan 31, 2022
|
Sorry did not mean to get in the way here ! |
This was referenced Jan 31, 2022
bjlittle
pushed a commit
that referenced
this pull request
Feb 1, 2022
* v3.2.0rc0 whats new and version string (#4557) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 21.12b0 → 22.1.0](psf/black@21.12b0...22.1.0) - [github.com/asottile/blacken-docs: v1.12.0 → v1.12.1](adamchainz/blacken-docs@v1.12.0...v1.12.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: lbdreyer <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Updates version string to 3.2.0rc0
Moved whats new dev.rst -> 3.2.rst
Consult Iris pull request check list