Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline to satisfy setuptools #4418

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

wjbenfold
Copy link
Contributor

🚀 Pull Request

Description

In 59.0.0, on 12/11/21, setuptools introduced a breaking change that no longer allows multi-line descriptions. This has caused nox to fail when running the tests with a ValueError.


Consult Iris pull request check list

Copy link
Member

@jamesp jamesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, we might want to change this back later for stylistic reasons when the setuptools bug has been fixed. @wjbenfold can you add a todo to check back on it in a few weeks?

@jamesp jamesp merged commit 7434c53 into SciTools:main Nov 15, 2021
@wjbenfold
Copy link
Contributor Author

Approved, we might want to change this back later for stylistic reasons when the setuptools bug has been fixed. @wjbenfold can you add a todo to check back on it in a few weeks?

Will do

@wjbenfold wjbenfold deleted the wjbenfold-setup-cfg-newline branch November 16, 2021 09:19
@wjbenfold
Copy link
Contributor Author

Approved, we might want to change this back later for stylistic reasons when the setuptools bug has been fixed. @wjbenfold can you add a todo to check back on it in a few weeks?

Doesn't look like setuptools have any intention to revert or change this - we could propose a change to their code but this is minor enough that it doesn't seem worth it

@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 23, 2021

we could propose a change to their code but this is minor enough that it doesn't seem worth it

Agreed, particularly since the conversation elsewhere has generally been highlighting that the chance to act was during the long period while the DeprecationWarning was being raised.

tkknight added a commit to tkknight/iris that referenced this pull request Dec 7, 2021
* main: (23 commits)
  Suggest type hinting (SciTools#4390)
  area weight regrid test fixes (SciTools#4432)
  Update latest.rst (SciTools#4425)
  Added @wjbenfold to the core dev list (SciTools#4423)
  Removed addition of period from wrap_lons. (SciTools#4421)
  Add release docs sections describing the role of a Release Manager (SciTools#4413)
  Subset should always return None if no value matches are found (SciTools#4417)
  What's new for SciTools#4400 (SciTools#4422)
  `iris.analysis.AreaWeighted` regrid speedup (SciTools#4400)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4419)
  Remove newline to satisfy setuptools (SciTools#4418)
  Updated environment lockfiles (SciTools#4416)
  NAME loader fixes (SciTools#4411)
  Updated whatsnew for PR 4402 (SciTools#4410)
  Support test data in benchmark workflows (SciTools#4402)
  What's new for pr 4387 (SciTools#4405)
  Make concat mismatch warning for scalar coords more accurate (SciTools#4387)
  Added line to latest release notes for updates to pp_save_rules.py (SciTools#4404)
  Update pp_save_rules.py (SciTools#4391)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4403)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants