Default connectivity start_index #4224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
trexfeathers
reviewed
Jul 5, 2021
|
Your proposal will certainly be OK, but I would be open to use modifying |
No I have no real preference, so happiest to take the least-change way But tests are failing now, looks like the merge is not delivering a good merge on imagerepo.json. |
|
Rebase doesn't do anything, as it is down to a change in test-iris-imagehash, and the matching Iris change (to remove a ref) is on the main branch 😞 The latest change here mirrors that. |
|
Closed in favour of #4231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Allow 'start_index' to default to 0 when creating Connectivity from a file-var, if var has no 'start_index' attribute.
Consult Iris pull request check list