optimise pre-commit #4208
Merged
optimise pre-commit #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
reviewed
Jun 24, 2021
pp-mo
reviewed
Jun 24, 2021
pp-mo
approved these changes
Jun 24, 2021
|
Nice work @bjlittle ! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 21, 2021
* main: (43 commits) [pre-commit.ci] pre-commit autoupdate (SciTools#4244) Updated environment lockfiles (SciTools#4242) [pre-commit.ci] pre-commit autoupdate (SciTools#4239) Documented the --force option on conda env create (SciTools#4240) Updated environment lockfiles (SciTools#4237) pre-commit isort and black --check only for cirrus-ci (SciTools#4235) Only run docs-building sessions with Python 3.8. (SciTools#4210) consolidate cirrus-ci documentation tasks (SciTools#4219) Updated environment lockfiles (SciTools#4223) Replace pyke nopyke (SciTools#4198) drop cirrus-ci minimal tests (SciTools#4218) remove change management tech paper (SciTools#4217) [pre-commit.ci] pre-commit autoupdate (SciTools#4213) Updated environment lockfiles (SciTools#4212) Widen cube printout for long ancil or cell-measure names. (SciTools#4124) convert docs print statements (SciTools#4209) optimise pre-commit (SciTools#4208) drop black and flake8 dependencies (SciTools#4181) pre-commit blacked docs (SciTools#4205) pre-commit update (SciTools#4204) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR plays to the strengths of
pre-commitand filters files at the right level before running the hooks.This configuration works for local developer commits on only the files that have changed (optimisation), and for
cirrus-ciwhenpre-commithooks are run against all files. In addition, the behaviour of the tools which the hooks call still honour their specific configuration.This undoes a major regression introduced in #4181. Oops 😊
Consult Iris pull request check list