Bump black version #4162
Bump black version #4162
Conversation
There was a problem hiding this comment.
we do require to include
blackfor those that want to testiriswithnoxon their local host.
Since Nox takes does its own pip install via Session.install(), I don't think this is true.
I therefore think we can get away with only requiring Black in the pre-commit config and in the noxfile. And we can have the noxfile read the pre-commit file to get a version. See my suggestions.
|
It's not necessarily all about As a minimal change dropping the pin seems appropriate. If we want to start to rationalise the dependencies that we explicitly include, then I think that's a different PR entirely - just so as to not muddy the waters here. |
|
I've got thoughts on how we can go about that, and I don't want to make that the focus of this PR. Also, it might be worth a separate dev discussion before committing changes to code. |
|
OK granted, but there is still a blocker to merging this one. Pre-commit is the gatekeeper for commits, while Nox is the gatekeeper for merging PR's. If anyone pushes a PR before we get round to merging a pre-commit auto-update, we will get a very confusing PR. So for me the bare minimum is getting Nox and pre-commit working with the same version. If there's something wrong with my suggestion I think we'll need to keep those two manually aligned as they are at the moment. |
|
Your suggested change only fits the use case for developer using I'm just going to backtrack and pin again. Safest option all round. |
|
@trexfeathers Nice one thanks. Slightly more interesting than I was bargaining for 😉 ... although worth thinking about 🤔 |
* master: refactor setup.py to setup.cfg (SciTools#4168) update docs pypi release (SciTools#4173) Update CI environment lockfiles (SciTools#4137) update CONTRIBUTING.md (SciTools#4165) RTD support link update (SciTools#4166) drop py36 support (SciTools#4163) github issues contact link for discussions (SciTools#4164) Bump black version (SciTools#4162) Stop CI from clobbering commits on lockfile updates (SciTools#4157) [pre-commit.ci] pre-commit autoupdate (SciTools#4161) Add a method to return a CubeList from CubeList.copy() (SciTools#4094) Update black et al (SciTools#4155)
🚀 Pull Request
Description
This PR updates the
blackversion to the latest offering by unpinning.I did consider removing
blackfrom the list of dependencies, but we do require to includeblackfor those that want to testiriswithnoxon their local host.Rather than continually update the specific
blackversion in several places, I suggest we simply let theblackversion float to the latest version at environment package dependency resolve time, and allow thepre-commit-botto notify us when a later version ofblackis available to the community.Seems like a reasonable compromise to take here.
Consult Iris pull request check list