-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move whatsnew contributions #3816
move whatsnew contributions #3816
Conversation
docs/iris/src/whatsnew/latest.rst
Outdated
@@ -176,6 +187,10 @@ Documentation | |||
* Added a warning to the :func:`iris.analysis.cartography.project` function | |||
regarding its behaviour on projections with non-rectangular boundaries. | |||
|
|||
* Added an explanation to the user guide of how ``Units`` are handled during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to have a link to the section of documentation that is added. I assume it would be to this:
Suggest adding a .. _cube-maths_units:
anchor and then linking from this whats new entry.
@@ -27,7 +27,9 @@ Features | |||
dependency on `matplotlib`_ at ``v2.x``. Now that ``Python2`` support has | |||
been dropped, ``Iris`` is free to use the latest version of `matplotlib`_. | |||
|
|||
* `CF Ancillary Data`_ variables are now supported. | |||
* `CF Ancillary Data`_ variables are now supported, and can be loaded from and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be useful to link to an issue or pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkknight Glad to do that, but for consistency that should also be the case for all other whatsnew
entries...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make the whats new page more useful - we could keep this discussion separate to this PR so we do not block it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkknight Cool.
For this PR I'll add the relevant links per whatsnew
entry mentioned here. Then I'll raise a separate PR to add relevant links to all the other entries, if possible... just to separate concerns. Thanks 👍
@@ -109,6 +115,11 @@ Incompatible Changes | |||
:func:`iris.experimental.concatenate.concatenate` function raised an | |||
exception. | |||
|
|||
* When loading data from NetCDF-CF files, where a variable has no ``units`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be useful to link to an issue or pr?
A couple minor comments @bjlittle. I realise this PR is about moving the whats new entries into the new file |
@tkknight Awesome, thanks 🎉 |
…haul * upstream/master: move whatsnew contributions (SciTools#3816) Parse with packaging version (SciTools#3815) Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811) tidy issue templates (SciTools#3814) Legacy doc notice (SciTools#3813) Update issue templates Update issue templates Update issue templates Unpin Matplotlib and proj (SciTools#3762)
* master: Add template collapsible markdown section (SciTools#3823) Requirements re-haul (SciTools#3812) Automate pull request labels (SciTools#3819) move whatsnew contributions (SciTools#3816) Parse with packaging version (SciTools#3815) Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811) tidy issue templates (SciTools#3814) Legacy doc notice (SciTools#3813)
* master: (36 commits) Rework whatsnew into new scheme. (SciTools#3834) Lazy regridding with Linear, Nearest, and AreaWeighted (SciTools#3701) Iris readme minimal (SciTools#3833) Fix sphinx logger (SciTools#3832) whatsnew entry for dependencies (SciTools#3831) Added link to scitools.org.uk on the main index. (SciTools#3830) Updated Iris install instructions (SciTools#3817) Delete labeler.yml Delete label.yml Create label.yml Delete labeler.yml Update labeler.yml Update labeler.yml Add template collapsible markdown section (SciTools#3823) Requirements re-haul (SciTools#3812) Automate pull request labels (SciTools#3819) move whatsnew contributions (SciTools#3816) Parse with packaging version (SciTools#3815) Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811) tidy issue templates (SciTools#3814) ...
This PR tidies some valid
whatsnew/contrabutions
entries from the legacy and semi-automated mechanism, into the current and manualwhatsnew/latest
:These contributions are from older feature branches using the then valid legacy approach to documenting
whatsnew
entries, which were then merged tomaster
.