[FB] [PI-3585] Change default loading unit from "1" to "unknown" #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This PR is associated with improving the choice of default units, please target the default_units feature branch. |
|
@stephenworsley is this simply obsolete + should be closed ?? |
|
@pp-mo Yeah, good call. |
abooton
changed the title
abooton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses the loading part of #3585 and the remaining issues with quality flags discussed in #3358 and #3474. A NetCDF variable without a unit will be asigned a unit of "unknown" when loaded. When this is then saved, the resulting NetCDF file will now have no unit. This is particularly important in the case of quality flags where the convention is to be represented as a unitless NetCDF variable.