-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combined whatsnew entry for discontiguity checking and masking #3188
combined whatsnew entry for discontiguity checking and masking #3188
Conversation
Hmmm... it occurs to me now that I'm not sure whether to call this 'contiguity checking' or 'discontiguity checking'. I'm thinking it should probably be 'discontiguity checking' because this can easily be extended to 'discontiguity checking and masking'. I don't think that 'contiguity checking and masking' is as correct. |
👍 preferred to #3187 |
Yup, I prefer the combined whatsnew entry too 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corinnebosley this is definitely the preferred option, but I wonder if we can update the tone of the whatsnew per my suggestion.
@@ -0,0 +1,5 @@ | |||
* Users can now check their cubes for any discontiguities in bounds arrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the use of "users" here. It implies that (a) there's an 'us' (devs) and 'them' (users), and not only that but (b) the whatsnew is by devs and for devs, and that users should be a little uncomfortable to also be here.
That said, it's hard to write these things! You can avoid the 'us' vs 'them' problem by using "you" in place of "users", which is more friendly, or not cast the whatsnew in terms of a person at all:
The function "find_discontiguities_in_bounds" can be used to check for discontiguities in the bounds arrays of cube coordinates.
Additionally, discontiguous points in coordinates can be explicitly masked using "mask_data_at_discontiguities".
Or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I didn't expect you to hear you promoting use of the passive voice @dkillick !
Not that I object to that, but I know other people do.
I've put this change (augmented by @dkillick's suggestions) straight into the WhatsNew (#3192) instead of here. |
DO NOT MERGE YET.
Waiting for: