Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps the version for 2.1dev + v2.0x what's new tweaks #2937

Merged
merged 3 commits into from
Jan 12, 2018

Conversation

pelson
Copy link
Member

@pelson pelson commented Jan 11, 2018

Here are the doc changes I made directly to the v2.0.x branch. If we want to change them in any way, we would need a PR to the upstream/v2.0.x branch (happy to do that, or the reviewer can do it directly).

@pelson pelson requested a review from DPeterK January 11, 2018 16:13
@@ -121,7 +121,7 @@ def callback(cube, field, filename):


# Iris revision.
__version__ = '2.0.0rc1'
__version__ = '2.1.0dev1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev1 not dev0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coordinates to plot as the x and y axis of a plot.

* The cf_units dependency version has been updated to v1.2.0, which prints shorter
unit strings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included a little example with this whatsnew item - did you elect to leave it out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. No it wasn't intentional.

functionality is now delivered through :mod:`iris-grib`.

* In Iris v1 it was possible to configure Iris to log at import time through
:attr:`iris.config.LOGGING`. This capability has been removed in iris v2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this attribute actually still exist or will we end up with a broken link in the docs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also capitalise the last "iris" to be consistent with the other examples of the word in this point please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the what's new can be read at https://scitools-docs.github.io/iris/v2.0.x/whatsnew/2.0.html (once the cache is updated, it will also be available at http://scitools.org.uk/iris/docs/v2.0/whatsnew/2.0.html)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I've checked the built whatsnew and there isn't a link to LOGGING. It doesn't really impact the page though because the text falls back to preformatted.

* In Iris v1 it was possible to configure Iris to log at import time through
:attr:`iris.config.LOGGING`. This capability has been removed in iris v2.

* When coordinates have no well defined plot axis, iris.plot and iris.quickplot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to modules?

Also, 'axis' --> 'axes', probably. Update: In fact, I think that either works here. Up to you whether you change it or not.

* v2.0.x:
  Converted the contributions into the whatsnew.
Copy link
Member

@DPeterK DPeterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy now the new version string has been corrected. The suggested doc changes can be done elsewhere – @pelson perhaps you could link the doc change PR to this when you raise it?

@DPeterK DPeterK merged commit a25d32e into SciTools:master Jan 12, 2018
@pelson pelson deleted the 2.1dev branch January 12, 2018 11:18
@QuLogic QuLogic added this to the v2.1.0 milestone Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants