-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document replacement of "iris.fileformats.ff" and "iris.experimental.fieldsfile". #2850
Conversation
```:meth:iris.experimental.fieldsfile.load```, which specifically performed | ||
fast loading from _either_ PP or FF files. | ||
Instead, please enable `:meth:iris.fileformats.um.structured_um_loading` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not make it clear what the replacement is, it needs to be explained in more detail, an example may be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this will cross reference the docs at http://scitools.org.uk/iris/docs/latest/iris/iris/fileformats/um.html#iris.fileformats.um.structured_um_loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will cross reference the docs at ... iris.fileformats.um.structured_um_loading
Yes, I thought that would be good enough : as it's only a whatsnew item, I think it can be a pointer rather than full info, no ?
@ajdawson - I merged this based on the responses to your review comment. I'm totally happy to improve the wording of the what's new wherever we can. Given the xrefs, would you still like to see the example added / some more detail? We can definitely action some more work on this if so. 👍 |
It would be clearer if you just said it was a context manager in the what's new, it avoids clicking a link just to find that out. |
Re-reading, I must agree it's still not terribly clear. |
Closes #2818.