Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document replacement of "iris.fileformats.ff" and "iris.experimental.fieldsfile". #2850

Merged
merged 2 commits into from
Oct 26, 2017

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 24, 2017

Closes #2818.

```:meth:iris.experimental.fieldsfile.load```, which specifically performed
fast loading from _either_ PP or FF files.
Instead, please enable `:meth:iris.fileformats.um.structured_um_loading` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not make it clear what the replacement is, it needs to be explained in more detail, an example may be useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cross reference the docs at ... iris.fileformats.um.structured_um_loading

Yes, I thought that would be good enough : as it's only a whatsnew item, I think it can be a pointer rather than full info, no ?

@pelson pelson added this to the v2.0.0 milestone Oct 24, 2017
@pelson pelson merged commit 313298e into SciTools:master Oct 26, 2017
@pelson
Copy link
Member

pelson commented Oct 26, 2017

@ajdawson - I merged this based on the responses to your review comment. I'm totally happy to improve the wording of the what's new wherever we can. Given the xrefs, would you still like to see the example added / some more detail? We can definitely action some more work on this if so.

👍

@ajdawson
Copy link
Member

It would be clearer if you just said it was a context manager in the what's new, it avoids clicking a link just to find that out.

@pp-mo
Copy link
Member Author

pp-mo commented Oct 26, 2017

Re-reading, I must agree it's still not terribly clear.
It should be reviewed by someone constructing release notes, but all the same I think I will propose a further change...
#2867

@pp-mo pp-mo deleted the ff_and_pp_changes branch January 15, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants