Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Note about collapsing multi-dimensional coordinates #1819

Merged
merged 2 commits into from
Nov 23, 2015

Conversation

DPeterK
Copy link
Member

@DPeterK DPeterK commented Oct 28, 2015

Adds a note on partially collapsing multi-dimensional coordinates to the userguide §9.1, iris.cube.Cube.collapsed and iris.coords.Coord.collapsed.


Instead you must either fully collapse the coordinate (in this case
requiring that both ``grid_latitude`` or ``grid_longitude`` coordinates be
collapsed together in a single collapse operation) or not collapse the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third option - remove the surface altitude.

@pelson
Copy link
Member

pelson commented Oct 30, 2015

👍 in principle. My major hesitation is on the addition to the userguide. Could you take a look at the built userguide, and tell me if you think the addition makes the flow work as well in the context of it being a document designed to be used as a readable narrative? The addition to the reference documentation I am absolutely 👍 on.

@@ -98,6 +98,22 @@ in the gallery takes a zonal mean of an ``XYT`` cube by using the
``collapsed`` method with ``latitude`` and ``iris.analysis.MEAN`` as arguments.


.. note::
You cannot partially collapse a multi-dimensional coordinate. Thus in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action: make into a single sentence and cross reference "reference docs".

@DPeterK
Copy link
Member Author

DPeterK commented Nov 23, 2015

As per @pelson's suggestions above, I have:

  • simplified the addition to the userguide by removing the note directive and almost all of the information,
  • placed the information removed from the userguide into the note directive in the docstring for iris.cube.Cube.collapsed and added a ref directive for this note, and
  • added a link to this note to the userguide and the docstring for iris.coords.Coord.collapsed, which I have also simplified in favour of this link.

pelson added a commit that referenced this pull request Nov 23, 2015
DOC: Note about collapsing multi-dimensional coordinates
@pelson pelson merged commit 66a8fa9 into SciTools:master Nov 23, 2015
@QuLogic QuLogic added this to the v1.10 milestone Nov 23, 2015
agbutteriss added a commit to agbutteriss/iris that referenced this pull request Aug 4, 2016
agbutteriss added a commit to agbutteriss/iris that referenced this pull request Aug 10, 2016
@DPeterK DPeterK deleted the collapse_2d_coord_note branch November 9, 2016 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants