Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pycarto++ #119

Closed
wants to merge 31 commits into from
Closed

Pycarto++ #119

wants to merge 31 commits into from

Conversation

rhattersley
Copy link
Member

No description provided.

bblay and others added 27 commits September 27, 2012 13:58
@bblay @esc24
cartopy replaces basemap
1f3b37f
@bblay @esc24
safe image changes
c96a699
@bblay @esc24
cautious changes
3480056
@esc24
Fixes to use renamed as_cartopy_crs/as_cartopy_projection methods.
8b21acb
@esc24
Visual test updates following migration to cartopy. Note the longitud…
b6f980e 
…e shift due to the default centering of maps.
@pelson
Fixed extent calculation. General improvements.
a6e3af2
@pelson
2 more tests passing.
2c66d0f
@esc24
Merge pull request #2 from pelson/mapping_fix
15d3bd4 
Mapping fix
@pelson
Fixed extent issue with infinite values.
558d0b4
@esc24
Initial fixes to extests. Issues around bounds and polygons remain.
10c84de
@esc24
Visual test updates following shift and margin fixes.
0bb2366
@esc24
More minor fixes to mapping and cartography.
cf69468
@pelson
Fixed further extent calculation issues (by removing the map_setup an…
2789ca0 
…d letting it get done automatically).
@esc24
Merge branch 'mapping_fix' of https://github.com/pelson/iris into pel…
7bdea1e 
…son-mapping_fix
@rhattersley
Scatter plot is OK
37a0224
@rhattersley
Update passing tests.
bcb51b0
@rhattersley
Remove duplicate method.
23a9e28 
Factor out cartopy axes creation.
@rhattersley
Revert scatter workaround - fixed in cartopy PR 58.
16f67e9
@rhattersley
Accept coloured outlines - it's MPL's problem.
304f660
@rhattersley
Accept "baggy" limits - it's what MPL does for scatter.
7ef4f36
@rhattersley
Test xy_range with global and local GeogCS
63f9d04
@rhattersley
Revert unnecessary change.
6bbecb9
@bblay
circular grib lons
8b2fc53
@rhattersley
Simplify rotated pole example and accept TEC plot
7abf2b9
@bblay
review actions and minor tidy
e221228
@rhattersley
Merge pull request #2 from bblay/gribcirc2
2679f3b 
GRIB load sets `circular`
@rhattersley
Accept new COP/ensemble maps
19f05c0
@rhattersley
Copy link
Member Author

Awaiting resolution of SciTools/cartopy#58 and SciTools/cartopy#60.

@esc24 esc24 mentioned this pull request Oct 2, 2012
Closed
pelson
pelson reviewed Oct 3, 2012
View reviewed changes
lib/iris/analysis/cartography.py

def get_lat_lon_grids(cube):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This api change should be documented as a non-compatible change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Similarly for lat_lon_range() and get_lat_lon_contiguous_bounded_grids(). Will need to revisit if we move the "xy" equivalents to the plot module.

@pelson
Copy link
Member

pelson commented Oct 3, 2012

This is looking good. I've made a couple of comments, but I have no doubt that we can merge this in the next couple of hours.

@pelson
Copy link
Member

pelson commented Oct 3, 2012

Some other points:

  • It would be nice to have a rotated pole example not in its native coordinate system. (be it TEC, or one of the specific rotated pole examples)
  • The Cynthia Brewer notice is highly annoying, particularly on the GloSea example (which has 12 plots, each with their own notice that this is using the color scheme. Can we not just remove the notice?

@rhattersley
Copy link
Member Author

I've made a couple of comments...

A couple?! ;-) I'll do what I can with some of the issues, but it'd help if you could muster @esc24 & @bblay for some of the changes they were originally responsible for.

It would be nice to have a rotated pole example not in its native coordinate system.

Perhaps. Personally I like the way the data is now nice and square and the coastlines are distorted to fit. But if we do decide to have a BendyPlot(tm), it should be handled in a separate PR.

The Cynthia Brewer notice is highly annoying...

Yes. There are too many of them. And it'd be nicer to have them outside the axes. But that's a matter for a new PR too.

@pelson
Copy link
Member

pelson commented Oct 3, 2012

@rhattersley : What is your desired stratergy here? I'd be happy enough to merge and address some of my comments in a separate PR (which should be done before 1.0)?

@pelson pelson mentioned this pull request Oct 3, 2012
Merged
@rhattersley rhattersley mentioned this pull request Oct 3, 2012
Merged
@rhattersley
Copy link
Member Author

Replaced by squashed PR #126.

@rhattersley rhattersley closed this Oct 3, 2012
@esc24 esc24 mentioned this pull request Oct 3, 2012
Closed
This was referenced Oct 3, 2012
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhattersley @pelson @esc24 @bblay