-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support numpy2 #580
Support numpy2 #580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 89.60% 89.61%
=======================================
Files 8 8
Lines 2473 2475 +2
Branches 420 420
=======================================
+ Hits 2216 2218 +2
Misses 159 159
Partials 98 98 ☔ View full report in Codecov by Sentry. |
I tested this locally and it does indeed eliminate this error:
But I still get these two errors:
|
Oh that's a bit weird : I didn't get that. |
It's in the failures for #550 |
This was proven to be caused by an unrelated Dask problem - SciTools/iris#6258 |
It seems that the only remaining problem for numpy2 is that the update to the code introduced here in #578 was causing tests to fail, when actually run with numpy 2.
I had meant to keep that issue separate from the eccodes 2v38 one, but somehow I tripped over my own commits.
This PR fixes that, so when merged it should unblock #550 🤞