Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep517: remove wheel dependency from build-system #437

Merged
merged 4 commits into from
Apr 22, 2024
Merged

pep517: remove wheel dependency from build-system #437

merged 4 commits into from
Apr 22, 2024

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Apr 18, 2024 •
edited
Loading

This pull-request removes the redundant inclusion of the wheel package as part of the build-system.

This is automatically included by the PEP517 compliant backend.

Resolves the following repo-review non-compliance:

image

@bjlittle bjlittle force-pushed the remove-wheel-pep517 branch from afbaf45 to 4019ad7 Compare April 19, 2024 10:53
pp-mo
pp-mo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pp-mo pp-mo merged commit 11cc99a into SciTools:main Apr 22, 2024
10 checks passed
@trexfeathers trexfeathers mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjlittle @pp-mo