Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdt6 & gdt140 #271

Closed
wants to merge 1 commit into from
Closed

pdt6 & gdt140 #271

wants to merge 1 commit into from

Conversation

marqh
Copy link
Member

@marqh marqh commented Jun 2, 2021

This PR targets new GRIB2 interpretation functionality, specifically:

  • GDT 3.140 (Lambert Azimuthal)
    • save (load already exists)
  • PDT 4.6 (percentile at a point in time)
    • load and save

There is no standard name in CF for percentile which seems like an omission to me, so i have used a long name.

I may like to propose a standard name of percentile to CF, which would then facilitate a change to the test code for PDT 4.6, but it seems challenging to wait for this, and significant datasets are being produced with long_name=='percentile'. I would also expect iris-grib to be backwards compatible with the use of long name, which I think is delivered by the implementation of the coords method (_save_rules#L1308)

@marqh
Copy link
Member Author

marqh commented Jun 2, 2021

hmm, looks like the test failure is due to blocking that may already be fixed by
#270

perhaps someone could update me when #270 is merged so I can rebase and rerun tests?
ty

@pp-mo pp-mo added this to the v0.18 milestone Jun 3, 2021
@pp-mo
Copy link
Member

pp-mo commented Feb 9, 2022

Hi @marqh
Just stumbled on this again.
given #270 resolved, could you now try rebasing ?

@trexfeathers
Copy link
Contributor

Replaced by #295.

@trexfeathers trexfeathers mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants