Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus CI #250

Merged
merged 57 commits into from
Mar 2, 2021
Merged

Cirrus CI #250

merged 57 commits into from
Mar 2, 2021

Conversation

jamesp
Copy link
Member

@jamesp jamesp commented Feb 24, 2021

Cirrus CI configuration and nox test harness to run all tests.

nox configuration is based on iris, but with a few new functions to support iris and iris test-data-dir.

This should be a complete replication of the Travis CI test suite. It performs all tests against both the version of iris on conda forge, and the current master branch of github.com/scitools/iris.

Known failures:

  • Python 3.8 tests currently fail. This appears to be a CML attribute sorting issue as experienced with iris py3.8 support.
  • flake and black linting fail. These tests are currently forced to return success in cirrus.

pp-mo and others added 30 commits October 6, 2020 16:36
…s#231)

* Travis test with  both Iris latest-release and latest-master.

* Modify test CMLs for latest Iris (Iris3.0 changes).

* Grib1 load fixes.

* Fix loading since units=None default for Iris3 coords

* Modify test to work with latest Iris (Iris3.0 changes).

* Test against latest Iris only.

* Review changes.
…ls#234)

* Rename Iris test-version options, and enable all to check action.

* Review changes.
* Require Iris >=3 (just for the gdt90 changes).

* Whatsnew entry for requiring Iris 3.

* Set version string for release candidate.

* Test against Iris 3.0.0rc0 from conda-forge/rc_iris.
* Add 'main' conda-forge channel, needed for docs builds.

* Use fixed spherical-earth-radius in GRIB1, ignoring change in gribapi default.

* Codestyle fix.
* Document PR#240 in release notes.

* Fix version string and release-notes date.
Copied across cirrus file from iris-ugrid
Borrowing from iris and iris-ugrid, added nox testing and a test runner.

Tests currently fail on my local machine.
This resolves the same bash issue as SciTools/iris#4019
@jamesp jamesp linked an issue Feb 24, 2021 that may be closed by this pull request
@jamesp jamesp requested a review from lbdreyer February 24, 2021 16:23
@bjlittle bjlittle self-assigned this Feb 25, 2021
@bjlittle
Copy link
Member

@jamesp I've turned off travis-ci on https://travis-ci.org/ for iris-grib

@bjlittle
Copy link
Member

bjlittle commented Feb 25, 2021

@jamesp I think that we may have to limit iris-grib testing to python<3.8 for now.

Certainly until iris 3.1 is released, at that point we can unpin python for iris-grib and it will pull in the goodness of SciTools/iris#3976

What do you think?

.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.821% when pulling a9d80d7 on jamesp:cirrus into e2dc18a on SciTools:master.

@coveralls
Copy link

coveralls commented Mar 1, 2021

Coverage Status

Coverage remained the same at 92.821% when pulling 69603d9 on jamesp:cirrus into e2dc18a on SciTools:master.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesp Cookin' with gas! 🚀 💯

Only a couple of minor questions to service, otherwise let's get this merged 👍

requirements/ci/py37.yml Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Show resolved Hide resolved
@jamesp jamesp requested a review from bjlittle March 2, 2021 11:28
requirements/test.txt Outdated Show resolved Hide resolved
@bjlittle bjlittle merged commit 1a8be59 into SciTools:master Mar 2, 2021
@bjlittle
Copy link
Member

bjlittle commented Mar 2, 2021

@jamesp Awesome contribution!

Thanks for pushing the over the line 🍻 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate testing from Travis to Cirrus
4 participants