Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at mesh to mesh #311

Merged
merged 15 commits into from
Nov 2, 2023
Merged

Conversation

HGWright
Copy link
Contributor

@HGWright HGWright commented Oct 10, 2023

Draft PR for adding Mesh to Mesh regridding functionality and testing.

Looking to make sure that all of the test work and cover all the additions, there may also be new things I need to add so draft for now.

Many test failiures expected.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023

CLA assistant check
All committers have signed the CLA.

@stephenworsley
Copy link
Contributor

By the way, I think the benchmarking failure has already been fixed in main (#297) so I think it ought to pass if you do a rebase.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes and you should be able to get these tests to pass.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small bits of documentation to add, otherwise this is getting pretty close to done.

esmf_regrid/schemes.py Show resolved Hide resolved
esmf_regrid/schemes.py Show resolved Hide resolved
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #311 (f20a62a) into main (4f685cf) will increase coverage by 0.06%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   98.75%   98.81%   +0.06%     
==========================================
  Files          33       34       +1     
  Lines        3680     3806     +126     
==========================================
+ Hits         3634     3761     +127     
+ Misses         46       45       -1     
Files Coverage Δ
...scheme/test_regrid_unstructured_to_unstructured.py 100.00% <100.00%> (ø)
...regrid/tests/unit/schemes/test_ESMFAreaWeighted.py 100.00% <ø> (ø)
...smf_regrid/tests/unit/schemes/test_ESMFBilinear.py 100.00% <ø> (ø)
esmf_regrid/tests/unit/schemes/test_ESMFNearest.py 100.00% <ø> (ø)
esmf_regrid/experimental/unstructured_scheme.py 92.85% <87.50%> (-1.27%) ⬇️
esmf_regrid/schemes.py 96.25% <87.50%> (+0.65%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephenworsley stephenworsley marked this pull request as ready for review November 2, 2023 16:33
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good work!

@stephenworsley stephenworsley merged commit b041fdb into SciTools:main Nov 2, 2023
15 checks passed
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Apr 25, 2024
* main: (42 commits)
  Update lockfiles and fix for new esmpy (SciTools#342)
  Fix for esmpy (SciTools#353)
  Fix usage of map_blocks (SciTools#338)
  Revert "Updated environment lockfiles (SciTools#335)" (SciTools#341)
  Updated environment lockfiles (SciTools#335)
  Bump actions/cache from 3 to 4 (SciTools#333)
  Bump actions/upload-artifact from 3 to 4 (SciTools#324)
  Bump actions/stale from 8.0.0 to 9.0.0 (SciTools#322)
  fix asv (SciTools#339)
  [pre-commit.ci] pre-commit autoupdate (SciTools#330)
  Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools#334)
  Updated environment lockfiles (SciTools#327)
  [pre-commit.ci] pre-commit autoupdate (SciTools#328)
  Updated environment lockfiles (SciTools#304)
  Add CITATION.cff (SciTools#319)
  updated for enums (SciTools#293)
  Flake8 compliant type checking. (SciTools#316)
  update to v0.10.dev0 (SciTools#314)
  Update to v0.9 (SciTools#313)
  First pass at mesh to mesh (SciTools#311)
  ...

# Conflicts:
#	CHANGELOG.md
#	esmf_regrid/esmf_regridder.py
#	esmf_regrid/schemes.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants