Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.7 #273

Merged
merged 1 commit into from
May 23, 2023
Merged

Update to v0.7 #273

merged 1 commit into from
May 23, 2023

Conversation

stephenworsley
Copy link
Contributor

To be merged only after #272

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #273 (eb0838a) into main (7a98c7d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          33       33           
  Lines        3563     3563           
=======================================
  Hits         3520     3520           
  Misses         43       43           
Impacted Files Coverage Δ
esmf_regrid/__init__.py 44.44% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM !

Assuming, as I think, there is as yet no automation of versioning, and the version is solely controlled by setting __version__ in /__init__.py ?
(I did search and it seems consistent).

@pp-mo
Copy link
Member

pp-mo commented May 23, 2023

Thanks @stephenworsley
All ok AFAICT
If you take out of draft, I will merge !

@stephenworsley stephenworsley marked this pull request as ready for review May 23, 2023 12:20
@stephenworsley
Copy link
Contributor Author

@pp-mo Yes, we're looking to add automatic versioning later.

@pp-mo pp-mo merged commit 2001de7 into SciTools:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants