-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RefinedGridInfo class (for potential Hovmoller/zonal mean support) #165
Add RefinedGridInfo class (for potential Hovmoller/zonal mean support) #165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 99.51% 99.40% -0.11%
==========================================
Files 27 28 +1
Lines 2469 2705 +236
==========================================
+ Hits 2457 2689 +232
- Misses 12 16 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Lint failure: see SciTools/iris#4668 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
648b59c
to
375bc4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stephenworsley, here's half a review (pre force-push).
esmf_regrid/tests/unit/experimental/unstructured_scheme/test_GridToMeshESMFRegridder.py
Outdated
Show resolved
Hide resolved
...egrid/tests/unit/experimental/unstructured_scheme/test_regrid_rectilinear_to_unstructured.py
Show resolved
Hide resolved
...egrid/tests/unit/experimental/unstructured_scheme/test_regrid_unstructured_to_rectilinear.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I was closer to finishing than I thought! Here's the final comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work as usual @stephenworsley!
Adds the RefinedGridInfo class. This class is designed to better handle grids with particularly large cells. These grids would typically have large innacuracies due to the difference between lines of latitudes and great circles, and in some cases, e.g. full latitude/longitude bounds, these could not even be represented in ESMF. This class solves these problems by having their ESMF representations be a "refinement" of the original grid by either increasing the longitude resolution by a desired factor, or else by increasing the latitude resolution sufficiently to be representable. This becomes especially usefull in the case of deriving Hovmoller plots.