-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixlocks #470
Fixlocks #470
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 6 6
Lines 800 800
Branches 105 105
=======================================
Hits 723 723
Misses 64 64
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Learning notes ... It's not at all clear what is going on :
|
43e9bc0
to
c7c7b8f
Compare
UPDATE Tues 2024-09-24After a whole lot of investigation, and multiple dead ends... It seems that this line was the critical thing
ReasonThis happened, I think, because conda-forge now delivers only ".conda", instead of ".bz2" files. Hence newer versions of many packages were excluded. |
Still to doWe should check this for real, after merging this, to demonstrate that an automatically triggered operation (as opposed to manual) can still create the expected PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got there in the end! Thanks @pp-mo
@@ -13,7 +13,7 @@ dependencies: | |||
# core dependencies | |||
- antlr-python-runtime 4.11.1.* # To update this, see cf_units/_udunits2_parser/README.md | |||
- cftime>=1.2 | |||
- numpy==1.26.4 | |||
- numpy<2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note
* main: [DOCS] Update docstring for date2num (module function) (SciTools#483) Modernise setup scripts (SciTools#484) Make antlr optional (SciTools#423) Ruff: smaller steps (SciTools#364) Updated docstring for num2date. (SciTools#467) updated conda lock files (SciTools#479) Revert to 00:03 Mondays for lockfile updates. (SciTools#480) New trigger time for GMT. (SciTools#478) Check lockfile updates @ 3pm daily (temporary for testing). (SciTools#477) Fixlocks (SciTools#470) # Conflicts: # pyproject.toml # requirements/cf-units.yml # requirements/locks/py310-lock-linux-64.txt # requirements/locks/py310-lock-osx-64.txt # requirements/locks/py310-lock-win-64.txt # requirements/locks/py311-lock-linux-64.txt # requirements/locks/py311-lock-osx-64.txt # requirements/locks/py311-lock-win-64.txt # requirements/locks/py312-lock-linux-64.txt # requirements/locks/py312-lock-osx-64.txt # requirements/locks/py312-lock-win-64.txt
Addresses #466
From the actions panel, it appears that the lockfile updates were successfully occurring with the previous py39/py310/py311 version.
But this broke for python 3.12 versions, when python versions were updated.
Also ... Prior to the Python version update, the lockfiles update action seemed to be working, but did not generate PRs as expected.
It may be simply that the target branch "" had been removed, and the actions have permission to update that, but not to (re-)create it. We will check that subsequently ...