remove CHANGES file #351
Merged
remove CHANGES file #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Looks like these are changes from before cf_units was moved out of Iris, so could be more awkward to find (particularly if you didn't know cf_units used to be part of Iris). OTOH I'd never seen this file before, and didn't think to look here when I was previously trying to find old Unit changes in Iris. I also don't think this file is comprehensive.
So I give you an approval and you can self-merge if you like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR purges the
CHANGESfile, which IMHO is simply a redundant historical file.If anyone is really interested in it, then it's captured in our GitHub repo history.
Note that, if we merge this after #350, then we should remove the
exclude CHANGESentry from theMANIFEST.in... or do the same in #350 if this PR is merged first.