Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup method is not a test #332

Merged
merged 1 commit into from
Jan 6, 2023
Merged

setup method is not a test #332

merged 1 commit into from
Jan 6, 2023

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Jan 6, 2023

🚀 Pull Request

Description

Pytest was throwing a warning because it ran this method as a test, and tests shouldn't return anything. Changing the name ensures pytest doesn't think it's a test.

lbdreyer
lbdreyer approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcomer ! Good to get this fixed since the pytest warning states that it will become a error in future pytest versions

@lbdreyer lbdreyer merged commit fedca42 into SciTools:main Jan 6, 2023
@rcomer rcomer deleted the fix-setup-method branch January 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbdreyer lbdreyer lbdreyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcomer @lbdreyer