Configure + enable stickler testing. #970
Conversation
| @@ -746,7 +747,6 @@ def quick_vertices_transform(self, vertices, src_crs): | |||
| mod = np.diff(src_crs.x_limits)[0] | |||
| bboxes, proj_offset = self._bbox_and_offset(src_crs) | |||
| x_lim = xs.min(), xs.max() | |||
| y_lim = ys.min(), ys.max() | |||
| for poly in bboxes: | |||
There was a problem hiding this comment.
@pp-mo What's happened to y_lim?
There was a problem hiding this comment.
'y_lim' was not used, so flake8 complained about it, so I got rid of it.
There's a lot of that going on in this PR !
| @@ -1184,7 +1184,6 @@ def __init__(self, central_longitude=0.0, central_latitude=0.0, | |||
| globe=globe) | |||
|
|
|||
| a = np.float(self.globe.semimajor_axis or WGS84_SEMIMAJOR_AXIS) | |||
| b = np.float(self.globe.semiminor_axis or WGS84_SEMIMINOR_AXIS) | |||
| lon, lat = central_longitude + 180, - central_latitude + 0.01 | |||
There was a problem hiding this comment.
@pp-mo And also what's happened to b (the semiminor axis)?
There was a problem hiding this comment.
'b' also not used anywhere.
As it was identical, I suspect this one was a mistake from the first.
There was a problem hiding this comment.
Identical to 'a'.
If it was going to be useful, I'd expect it to be different in some way, but it's all just guesswork.
There was a problem hiding this comment.
It's not identical to 'a', though. But I'm not sure it needs to be used anyway.
There was a problem hiding this comment.
Oh I see, it is not after all : more care required !
lib/cartopy/__init__.py
Outdated
| @@ -108,4 +108,4 @@ | |||
| # Commonly used sub-modules. Imported here to provide end-user | |||
| # convenience. | |||
| import cartopy.crs | |||
| import cartopy.feature | |||
| import cartopy.feature # noqa: F401 (imported but not used) | |||
There was a problem hiding this comment.
Does this comment stop Stickler complaining?
There was a problem hiding this comment.
Yes, it's a specific indication to the flake8 tester, actually the "pyflakes" component
The bit in brackets is just comment to the reader.
If anyone is interested ...
It's really not very clearly explained, but after a bit of digging http://flake8.pycqa.org/en/latest/user/violations.html
So, "F" numbers are errors from pyflakes, and "E" and "W" numbers are from pycodestyle (pep8-successor).
I think I'll edit to make this clearer (but it ain't always easy getting it all on one line, which seems to be required)
There was a problem hiding this comment.
I'm happy with all these changes. Seems fine to me. Good job @pp-mo
| l = list(zip(np.zeros(n_steps) + x, | ||
| np.linspace(min(y_ticks), max(y_ticks), n_steps))) | ||
| lines.append(l) | ||
| ticks = list(zip( |
There was a problem hiding this comment.
I could've sworn I'd written some optimization for this unfortunate type conversion; maybe I never made a PR out of it, but I can see if I can dig it up.
There was a problem hiding this comment.
I don't see a need to connect this with the issue at hand ?
We rather want to get this onto master so we can get on right now, since stickler is now complaining about various open PRs.
| @@ -249,7 +249,7 @@ def test_pcolormesh_global_with_wrap1(): | |||
| @ImageTesting(['pcolormesh_global_wrap2']) | |||
| def test_pcolormesh_global_with_wrap2(): | |||
| # make up some realistic data with bounds (such as data from the UM) | |||
| nx, ny = 36, 18 | |||
| nx = 36 | |||
| xbnds, xstep = np.linspace(0, 360, nx - 1, retstep=True, endpoint=True) | |||
| ybnds, ystep = np.linspace(-90, 90, nx - 1, retstep=True, endpoint=True) | |||
There was a problem hiding this comment.
Seems better to make this ny (but that would require changing ny since it was not used before.)
There was a problem hiding this comment.
Really probably just n, but I don’t think it’s really worth worrying about.
There was a problem hiding this comment.
Ok, yes I hadn't spotted it -- it looks like that was the error.
Fixed..
| @@ -249,7 +249,7 @@ def test_pcolormesh_global_with_wrap1(): | |||
| @ImageTesting(['pcolormesh_global_wrap2']) | |||
| def test_pcolormesh_global_with_wrap2(): | |||
| # make up some realistic data with bounds (such as data from the UM) | |||
| nx, ny = 36, 18 | |||
| nx = 36 | |||
| xbnds, xstep = np.linspace(0, 360, nx - 1, retstep=True, endpoint=True) | |||
| ybnds, ystep = np.linspace(-90, 90, nx - 1, retstep=True, endpoint=True) | |||
There was a problem hiding this comment.
Really probably just n, but I don’t think it’s really worth worrying about.
|
Hi @QuLogic if we have your interest, would you consider merging this ? |
* Configure + enable stickler testing with flake8.
No description provided.