-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalebar #1728
base: main
Are you sure you want to change the base?
Scalebar #1728
Conversation
…cartopy's original master branch has been updated by the addition of the scalebar method in the geoaxes. A test and an example files of the scalebar method are also provided
…onalities here provided. The prior developers branch had several commits which were aggregated into this single 1st commit. Add a warning and comments This is the commit that antecedes all added new commits in respect to the pull request number SciTools#1693 from: SciTools#1693
… setting the number of ticks, and changing the decimal separators in the ticklabels
…ER. Now, the user can directly change the hemispheres (north-south and west-east) ticklabels ('N', 'S', 'W', 'E') from the gridliner instance. Also, new functionalities have been added to the gridliner
… been changed to be conform with flake8
…for the scalebar has been added
…calebar has been updated. Now, the fancy_scalebar has a proper documentation. Also, the geoaxes can directly create a scalebar
…ht added, following the cartopy contributors' standard'
…ive examples and tests. \n The changes here applied allow an easy assess and respective setting of the geoaxes.griline's ticklabels. The settings that can now be changed by the user are the following: \n a) the decimal separator (from dot '.' to any other string (i.e. from dot to comma ','); \n b) the number of decimal places after the coordinate (i.e.: {0:3f}); \n c) the labels of the east-west hemispheres ('W', 'E') - to any other set of labels (i.e.: 'Oeste', 'Leste'); \n d) the labels of the north-south hemispheres ('N', 'S') - to any other set of labels (i.e.: 'Norte', 'Sul'>.
…s of the gridliner module and submodules
…for better follow up. Furthermore, the new figure tests have the ImageTesting decorator in its functions.
…offset subclasses. TODO: there is still some problems regarding how to add the ticklabels into the scalebar's ticklabels...
description of the add_scalebar function was updated.
Running PEP8 (or whatever formatter you used) on everything is very confusing, as it muddles what it is you actually changed here. You also seem to have mixed in your other PR here, so I really don't know what to look at. |
numpy array's base method has been deleted within the "_point_along_line" function
numpy "base" method was dropped from the geodesic.inverse results.
Typo solved from the TextArea
The Old "AttributeError: module 'cartopy.crs' has no attribute 'PROJ4_VERSION' _________________ ERROR collecting tests/mpl/test_scalebar.py _________________ " has been solved in this Commit
Spacing error solved
typo solved
minimumdescent=True is now deprecated within matplotlib
Copied from the cartopy's master branch
It is now exactly equal to cartopy's master branch
@QuLogic, I have tried to clean all this confusion into this new commit. See if it helps. |
Just want to add this is exactly the feature I am looking for! Need any help getting this merged? |
Yes, please. I have done all I could do to facilitate the merge. Nevertheless, the time I updated this Pull Request, there were several LINT errors that would not allow a Merge. Therefore, I had to fix them all (even the ones that were not caused by this branch). As a consequence, it seems that this branch commit's history is now denser than the reviewers expected. Let me know if I can be of any service. Sincerely, |
Any update on the progress with this? If not, is there something a complete beginner to this particular toolbox could do to move it along? Would love to see this feature implemented! |
|
Issue #490
This Pull Requests closes #490
Rationale
In respect to the discussed in #490, here is an implementation of a scalebar for geoaxes.
The algorithm allows one to import the scalebar function directly from cartopy, or be directly called from the Goeaxes.
Implications
None applicable
Limitations:
So far, I have only been capable of inserting the scalebar without a background.
Here is an example for using it:
TODO:
Add some background for the scalebar
Code for generating the above examples: