Edit Mollweide boundary to avoid bug at poles #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenworsley
force-pushed
the
patch-projection-bug
branch
from
5ae4671 to
9944fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of the bug mentioned in #1333. When projecting to Mollweide, for latitudes above about 89.14 (or below -89.14), all points will be mapped to the pole. This causes potentially serious errors for things like contourf. My solution is to modify the boundary so that the pole is on the outside and no points on the boundary are mapped to the pole.
From what I understand about how projecting segments works, when a line segment is projected so that it crosses the boundary, cartopy will try and find a point on the original line which, when projected, will lie on the boundary. This means that so long as the boundary is outside of the problematic area, all projected line segments touching the boundary will be significantly more correct than what they would have been had they instead continued to the pole. This ought to prevent many of the problems with this projection.